Skip to content

updated localhost classes and tests #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chillaq merged 3 commits into from
Jan 22, 2026
Merged

updated localhost classes and tests #618

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4327a30
updated localhost classes and tests
chillaq Jan 22, 2026
11d56fd
fixed typo for segment update type
chillaq Jan 22, 2026
f2608fa
Merge branch 'FME-12276-async-classes' into FME-12226-events-localhost
chillaq Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed typo for segment update type
  • Loading branch information
@chillaq
chillaq committed Jan 22, 2026
commit 11d56fddf3333599a2a00bd8655f3c47943c7d9c
2 changes: 1 addition & 1 deletion splitio/events/events_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class SdkEventType(Enum):
"""Public event types"""

FLAG_UPDATE = 'FLAG_UPDATE'
SEGMENT_UPDATE = 'SEGMENT_UPDATE'
SEGMENTS_UPDATE = 'SEGMENTS_UPDATE'

class EventsMetadata(object):
"""Events Metadata class."""
Expand Down
12 changes: 6 additions & 6 deletions splitio/storage/inmemmory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def update(self, to_add, to_delete, new_change_number):
self._internal_event_queue.put(
SdkInternalEventNotification(
SdkInternalEvent.RB_SEGMENTS_UPDATED,
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))

def _put(self, rule_based_segment):
"""
Expand Down Expand Up @@ -290,7 +290,7 @@ async def update(self, to_add, to_delete, new_change_number):
await self._internal_event_queue.put(
SdkInternalEventNotification(
SdkInternalEvent.RB_SEGMENTS_UPDATED,
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))

async def _put(self, rule_based_segment):
"""
Expand Down Expand Up @@ -999,7 +999,7 @@ def put(self, segment):
self._internal_event_queue.put(
SdkInternalEventNotification(
SdkInternalEvent.SEGMENTS_UPDATED,
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))

def update(self, segment_name, to_add, to_remove, change_number=None):
"""
Expand All @@ -1025,7 +1025,7 @@ def update(self, segment_name, to_add, to_remove, change_number=None):
self._internal_event_queue.put(
SdkInternalEventNotification(
SdkInternalEvent.SEGMENTS_UPDATED,
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))

def get_change_number(self, segment_name):
"""
Expand Down Expand Up @@ -1140,7 +1140,7 @@ async def put(self, segment):
await self._internal_event_queue.put(
SdkInternalEventNotification(
SdkInternalEvent.SEGMENTS_UPDATED,
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))


async def update(self, segment_name, to_add, to_remove, change_number=None):
Expand All @@ -1166,7 +1166,7 @@ async def update(self, segment_name, to_add, to_remove, change_number=None):
await self._internal_event_queue.put(
SdkInternalEventNotification(
SdkInternalEvent.SEGMENTS_UPDATED,
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))


async def get_change_number(self, segment_name):
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_streaming_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def test_happiness(self):
sse_server.publish(make_segment_change_event('segment1', 1))
time.sleep(1)
assert self.update_flag
assert self.metadata[len(self.metadata)-1].get_type() == SdkEventType.SEGMENT_UPDATE
assert self.metadata[len(self.metadata)-1].get_type() == SdkEventType.SEGMENTS_UPDATE
flag = False
for meta in self.metadata:
if 'split2' in meta.get_names():
Expand Down
16 changes: 8 additions & 8 deletions tests/storage/test_inmemory_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,13 +811,13 @@ def test_internal_event_notification(self):
storage.put(segment)
event = events_queue.get()
assert event.internal_event == SdkInternalEvent.SEGMENTS_UPDATED
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
assert len(event.metadata.get_names()) == 0

storage.update('some_segment', ['key4', 'key5'], ['key2', 'key3'], 456)
event = events_queue.get()
assert event.internal_event == SdkInternalEvent.SEGMENTS_UPDATED
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
assert len(event.metadata.get_names()) == 0

class InMemorySegmentStorageAsyncTests(object):
Expand Down Expand Up @@ -893,13 +893,13 @@ async def test_internal_event_notification(self):
await storage.put(segment)
event = await events_queue.get()
assert event.internal_event == SdkInternalEvent.SEGMENTS_UPDATED
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
assert len(event.metadata.get_names()) == 0

await storage.update('some_segment', ['key4', 'key5'], ['key2', 'key3'], 456)
event = await events_queue.get()
assert event.internal_event == SdkInternalEvent.SEGMENTS_UPDATED
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
assert len(event.metadata.get_names()) == 0

class InMemoryImpressionsStorageTests(object):
Expand Down Expand Up @@ -2006,12 +2006,12 @@ def test_internal_event_notification(self, mocker):
rbs_storage.update([segment1, segment2], [], -1)
event = events_queue.get()
assert event.internal_event == SdkInternalEvent.RB_SEGMENTS_UPDATED
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
assert len(event.metadata.get_names()) == 0

rbs_storage.update([], ['some_segment'], -1)
assert event.internal_event == SdkInternalEvent.RB_SEGMENTS_UPDATED
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
assert len(event.metadata.get_names()) == 0

class InMemoryRuleBasedSegmentStorageAsyncTests(object):
Expand Down Expand Up @@ -2093,12 +2093,12 @@ async def test_internal_event_notification(self, mocker):
await rbs_storage.update([segment1, segment2], [], -1)
event = await events_queue.get()
assert event.internal_event == SdkInternalEvent.RB_SEGMENTS_UPDATED
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
assert len(event.metadata.get_names()) == 0

await rbs_storage.update([], ['some_segment'], -1)
event = await events_queue.get()
assert event.internal_event == SdkInternalEvent.RB_SEGMENTS_UPDATED
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
assert len(event.metadata.get_names()) == 0