This repository was archived by the owner on Nov 19, 2025. It is now read-only.
add SUGGEST_NULLABLE_ANNOTATIONS inspection#89
Merged
swankjesse merged 1 commit intosquare:mainfrom Jul 12, 2021
Merged
Conversation
add ConstantConditions.SUGGEST_NULLABLE_ANNOTATIONS to inspections. This inspection flags code that mixes `@Nullable` values and non-`@Nullable` params. Such code is likely erroneous and a common place for NPEs to hide.
acrowe-square
approved these changes
Jun 14, 2021
cheister
approved these changes
Jun 23, 2021
swankjesse
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ConstantConditions.SUGGEST_NULLABLE_ANNOTATIONS to inspections.
This inspection flags code that mixes @nullable values and non-@nullable params.
By Square Java convention, we treat unannotated method params as non-null by default.
Thus, code that mixes nullability in this way is likely incorrect, and creates an easy place for NPEs to hide.
With this change, a method call that passes a value IntelliJ determines to be possibly null into a method parameter not annotated as @nullable will be highlighted with the warning text,
Argument '<some possibly-null expression>' might be null but passed to non-annotated parameter.