NFC: BridgeJS: Remove dead cleanup infrastructure#655
Merged
krodak merged 1 commit intoswiftwasm:mainfrom Feb 18, 2026
Merged
Conversation
kateinoigakukun
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As discussed recently, we're not going with the type descriptor approach from #622. Instead, splitting the improvements into targeted PRs, as #622 even after the cleanup is a bit too much, as most likely we don't want to include all changes (even after the cleanup), so this approach should work better.
This is the first one - removing cleanup infrastructure that became dead code after #635 and #636.
What changed
After #635 (string lower no longer needs cleanup) and #636 (fixed JSObject? double-release in struct lowering), no type produces cleanup code at runtime. This PR removes all of it:
cleanupCodeprinter field fromIntrinsicJSFragment.PrintCodeContexttmpStructCleanupsarray andswift_js_struct_cleanupBJS handler from generated JS_swift_js_struct_cleanupextern and wrapper fromBridgeJSIntrinsics.swiftswift_js_struct_cleanupstub frominstantiate.jslower()no longer returns{ cleanup }- just pushes fields to stackslower()returns caseId directly instead of{ caseId, cleanup }() => { return () => ({...}); }simplified to() => ({...}); call-site()()becomes()init(unsafelyCopying:)no longer calls struct cleanup; lower extern returnsVoidinstead ofInt32strStack.push(textDecoder.decode(bytes))inlined (removed intermediate variable)