Open
Conversation
gcc (GCC) 14.1.1 20240701 (Red Hat 14.1.1-7) produces this:
network.c:159:57: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and no
t in the later argument [-Wcalloc-transposed-args]
159 | (struct read_lines_s *) safecalloc (sizeof (struct read_lines_s),
| ^~~~~~
Fix them.
Signed-off-by: Alexey Kardashevskiy <[email protected]>
The current "Bind" allows IP addresses which does not work with dynamically changing IPs such as VPN. Extend "Bind" to accept an interface name if SO_BINDTODEVICE is supported (Linux). For example, "Bind tun0". Signed-off-by: Alexey Kardashevskiy <[email protected]>
|
Different scenario here: I am using it on Linux computers to exclude some traffic from the VPN.
This pull request resolve these two issues.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding SO_BINDTODEVICE to "Bind" as I run it to access corporate network via VPN with a changing IP address, hence the fix. Please comment. Thanks.