The Wayback Machine - https://web.archive.org/web/20200914223420/https://github.com/TheAlgorithms/Python/pull/2242
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added type hints and doctests to arithmetic_analysis/intersection.py #2242

Merged
merged 1 commit into from Aug 1, 2020
Merged

added type hints and doctests to arithmetic_analysis/intersection.py #2242

merged 1 commit into from Aug 1, 2020

Conversation

@spamegg1
Copy link
Contributor

spamegg1 commented Jul 27, 2020

continuing #2128

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
@spamegg1
added type hints and doctests to arithmetic_analysis/intersection.py
Loading status checks…
76fb2bc 
continuing #2128
@spamegg1
Copy link
Contributor Author

spamegg1 commented Jul 27, 2020

Let's hope it goes better this time!
@swapnanildutta
swapnanildutta approved these changes Jul 31, 2020
View changes
@swapnanildutta
swapnanildutta approved these changes Jul 31, 2020
View changes
@itsvinayak
itsvinayak approved these changes Aug 1, 2020
View changes
@itsvinayak
Copy link
Member

itsvinayak commented Aug 1, 2020

@cclauss please have a look
@cclauss
cclauss approved these changes Aug 1, 2020
View changes
Copy link
Member

cclauss left a comment

The variable names (x0, x1, x_n, x_n1, x_n2), etc. make my head spin but these changes look good to me.
@spamegg1
Copy link
Contributor Author

spamegg1 commented Aug 1, 2020 •
edited

The variable names (x0, x1, x_n, x_n1, x_n2), etc. make my head spin but these changes look good to me.

I didn't want to change the existing algorithm too much. Maybe some cosmetic changes in the future.

Thanks for the reviews and approvals everyone!
@cclauss cclauss merged commit 9cda130 into TheAlgorithms:master Aug 1, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@itsvinayak itsvinayak

@swapnanildutta swapnanildutta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@spamegg1 @itsvinayak @cclauss @swapnanildutta
You can’t perform that action at this time.