Merged
Conversation
Contributor
fredevery
commented
Nov 8, 2017
fredevery
commented
- more logical test directory structure
fredevery
changed the title
LevKanter
suggested changes
Dec 12, 2017
Contributor
LevKanter
left a comment
LevKanter
left a comment
There was a problem hiding this comment.
@fredevery this is what I'm seeing when running the tests:
Also-- can you include a README file with just some basic notes on how to run the environment and test suite locally? (Even if it includes obvious stuff like "run yarn install" etc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.