fix/enhancement: added bytes32 name/symbol support in get_token()#191
Merged
ErikBjare merged 4 commits intouniswap-python:masterfrom Oct 28, 2021
Merged
fix/enhancement: added bytes32 name/symbol support in get_token()#191ErikBjare merged 4 commits intouniswap-python:masterfrom
ErikBjare merged 4 commits intouniswap-python:masterfrom
Conversation
Member
Author
|
@ErikBjare ^^ |
Member
|
Veeery nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173
get_token()call should beget_token("0x431ad2ff6a9c365805ebad47ee021148d6f7dbe0", "erc20b32")for tokens that have
nameandsymbolasbytes32and for the rest call remains the sameget_token("0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2")erc20b32.abi contains ABI for tokens that has both properties as bytes32. If there is a token with string+b32 or vice versa then all you need is create proper ABI for that and pass this ABI to
get_token().