feat: make_trade add optional route param#239
Open
starascendin wants to merge 4 commits intouniswap-python:masterfrom
Open
feat: make_trade add optional route param#239starascendin wants to merge 4 commits intouniswap-python:masterfrom
starascendin wants to merge 4 commits intouniswap-python:masterfrom
Conversation
ErikBjare
reviewed
Jul 13, 2022
| fee: int = None, | ||
| slippage: float = None, | ||
| fee_on_transfer: bool = False, | ||
| route: Optional[List[AddressLike]] = None, |
Member
There was a problem hiding this comment.
Might lead to unexpected behavior if route is specified but not respected (such as in the eth_to_token and token_to_eth cases).
ErikBjare
reviewed
Jul 13, 2022
| fee: int, | ||
| slippage: float, | ||
| fee_on_transfer: bool = False, | ||
| route: Optional[List[AddressLike]] = None, |
Member
There was a problem hiding this comment.
Same concern as above, needs to be respected in all cases, or raise an exception if it can't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.