Skip to content

Uniswap v4 support#340

Open
ErikBjare wants to merge 61 commits intomasterfrom
dev/v4
Open

Uniswap v4 support#340
ErikBjare wants to merge 61 commits intomasterfrom
dev/v4

Conversation

@ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Jul 4, 2023

Just a PR with all the changes in the dev/v4 branch.

Closes #337

@ErikBjare ErikBjare mentioned this pull request Jul 4, 2023
Open
liquid-8 and others added 5 commits August 21, 2023 17:29
@liquid-8
futhermore
24c3671
@liquid-8
Pool manager ABI added;
c91c767 
Poolid function fix;
Splitting methods to contract's calls wraps and market functions.
@liquid-8
Merge pull request #349 from liquid-8/dev
7f7cbe9 
 Pool manager ABI added;  Poolid function fix; Splitting methods to contract's calls wraps and market functions.
@liquid-8
UniswapV4 alpha
2f9e012
@liquid-8
Merge pull request #365 from liquid-8/dev
dbe104f 
UniswapV4 alpha
@ErikBjare ErikBjare marked this pull request as ready for review January 8, 2024 08:47
@codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 38.16425% with 128 lines in your changes missing coverage. Please review.

Project coverage is 52.26%. Comparing base (4f15d2e) to head (1fee875).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
uniswap/uniswap4.py 27.10% 121 Missing ⚠️
uniswap/util.py 20.00% 4 Missing ⚠️
uniswap/types.py 90.32% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #340       +/-   ##
===========================================
- Coverage   71.22%   52.26%   -18.97%     
===========================================
  Files          11       12        +1     
  Lines        1074     1280      +206     
===========================================
- Hits          765      669       -96     
- Misses        309      611      +302

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquid-8
Copy link
Member

liquid-8 commented Jun 6, 2024

@ErikBjare ^^

ErikBjare
ErikBjare commented Jun 10, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liquid-8 liquid-8 liquid-8 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uniswap v4 support

2 participants

@ErikBjare @liquid-8