Add Pancakeswap V3 trades support#376
Open
JohnDoe424242 wants to merge 1 commit intouniswap-python:masterfrom
Open
Add Pancakeswap V3 trades support#376JohnDoe424242 wants to merge 1 commit intouniswap-python:masterfrom
JohnDoe424242 wants to merge 1 commit intouniswap-python:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 84.20% 83.93% -0.27%
==========================================
Files 11 11
Lines 1057 1139 +82
==========================================
+ Hits 890 956 +66
- Misses 167 183 +16 ☔ View full report in Codecov by Sentry. |
|
Care to share an example script of how to call this? Additionally, things that have to change are the pair contract ABI. To make the |
Author
|
@Dewald928 unfortunately pools management is not implemented in this patch, trading only.
Nothing in particular, just like the regular code, except for the POA middleware |
|
I use this code but wrong，i dont know how to use the code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not full support for Pancakeswap V3, but now it's possible to recognize prices and make trades. Pancakeswap V3 is almost the same, but there are some differences, support for which I have added. I also added the
use_rpc_gas_priceoption to not sendtype 2transactions to BSC. But since BSC is not POS blockchain, in Web3 object you have to manually addgeth_poa_middleware.