feat: initial support for custom deployments and routes#58
Merged
ErikBjare merged 4 commits intouniswap-python:masterfrom May 4, 2021
Merged
feat: initial support for custom deployments and routes#58ErikBjare merged 4 commits intouniswap-python:masterfrom
ErikBjare merged 4 commits intouniswap-python:masterfrom
Conversation
Closed
Member
Author
|
As I mentioned in #62, it might be better to add the ability to override the router and factory contract addresses from the constructor parameters (since it generalizes support across all Uniswap clones). |
ErikBjare
changed the title
Closed
Closed
ErikBjare
changed the title
Member
Author
|
Tests pass locally (after fixing what I thought was the cause of #88). Not sure why they don't work in CI. Maybe because the token is secret and not available in PRs? Works now anyway, merging. |
ErikBjare
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very WIP.