Bugfix #126 - Suite descriptions are not aggregated#130
Merged
PhilippSalvisberg merged 5 commits intomainfrom Jan 4, 2021
Merged
Bugfix #126 - Suite descriptions are not aggregated#130PhilippSalvisberg merged 5 commits intomainfrom
PhilippSalvisberg merged 5 commits intomainfrom
Conversation
This ensures that the description of a child suite is not used for a parent suite when the parent suite does not have a description. This was the root cause of issue #126.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #126 - instead of aggregating suite descriptions the suites without descriptions are left as is.
The root cause of this bug was wrong deserialization of the XML document which used the first description found in a suite, even if it was the description of a child suite.