Correction: add missing label elm to 'button' naming steps #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds label element to `button`, `input type=button|submit|reset|image`. This is a long overdue update and there could be more clarity here. However, getting this perfect has long stood in the way of getting this done, and I would rather get this gap resolved to match reality, and then better describe this in a follow revision to these naming steps.
scottaohara
changed the title
cookiecrook
reviewed
Jul 14, 2022
Collaborator
cookiecrook
left a comment
cookiecrook
left a comment
There was a problem hiding this comment.
I feel like this HTML-AAM specific algorithm may start to get to complicated unless it's explicit where each of these steps fits into the main AccName algorithm. For example:
- Step 1 (aria-label, etc here) is redundant with AccName...
- Steps 2 and 3 (label el, value attr) fits into the "host language label mechanism" portion of AccName
- Steps 4 and 5 (title and placeholder attrs) fit into the host language tooltip mechanism portion of AccName.
- then the final step would be the element-specific fallback label
Member
Author
|
@cookiecrook yes, and this is where some of the cleanup i'm trying to do in another future PR would come into play. But there are some elements that don't fit neatly with the way that accName is setup. E.g., there are some elements where name from content (accName F) takes precedent over the |
Collaborator
|
Okay then. I approve this diff as-is. Thanks for the follow-up. |
cookiecrook
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds label element to
button,input type=button|submit|reset|image.This is a long overdue update and there could be more clarity here. However, getting this perfect has long stood in the way of getting this done, and I would rather get this gap resolved to match reality, and then better describe this in a follow revision to these naming steps.
Closes #357 - companion PR to #402
Preview | Diff