Conversation
|
hello anybody? |
satwikkansal
left a comment
satwikkansal
left a comment
There was a problem hiding this comment.
@darthgera123 Nice work, just a few minor changes requested :) Ping me here once addressed.
|
|
||
| This is a guide on how to use coala-bears for this project | ||
|
|
||
| This project consists of a .coafile which basically has all the guidelines |
There was a problem hiding this comment.
.coafile should be in codespace like .coafile
There was a problem hiding this comment.
.coafile is there in the codespace. This is just the documentation
| This is a guide on how to use coala-bears for this project | ||
|
|
||
| This project consists of a .coafile which basically has all the guidelines | ||
| that needs to be followed when working with coala.It can modified. |
There was a problem hiding this comment.
missing a space, "coala. It can..."
There was a problem hiding this comment.
And it should it with working with coala or working with wtfpython-web?
| This project consists of a .coafile which basically has all the guidelines | ||
| that needs to be followed when working with coala.It can modified. | ||
|
|
||
| In order to specify the files to analyze, you can use the --files argument. |
There was a problem hiding this comment.
code highlight --files
There was a problem hiding this comment.
btw we don't need --files argument
There was a problem hiding this comment.
you just need to run coala, and since .coafile is already present, settings would be supplied from there.
So instead of this section, you should add instructions to install coala using pip, and use it inside the project directory!
| You can also run coala in non interactive mode | ||
| `coala --non-interactive` | ||
|
|
||
| ###Auto-applying results |
There was a problem hiding this comment.
Instead of asking user to supply the flags, you can add default_actions in the .coafile.
Example: https://github.com/coala/coala-quickstart/blob/master/.coafile#L25
So adding this default section to the all section should do the job for us!
| `coala --non-interactive` | ||
|
|
||
| ###Auto-applying results | ||
| Coala includes a special setting called default_actions that allows you to set the |
There was a problem hiding this comment.
All this would no longer be needed one we add default action. We just need the instructions to install and run coala, that's all.
All the other changes should be made to .coafile which the other developers on wtfpython-web need not to worry about.
|
@darthgera123 please squash your commits and update the issue description to make it more informative. |
3 participants
NOTE:
Please fill out the template below
[. ] Did you read the instructions in the WORKFLOW ?
[. ] Is your Python code styled according to the PEP8 code style convention as mentioned here ?
[. ] Have you run the tests ?
[. ] Have you followed commit guidelines as mentioned here ?
This adds the coafile and a small guide to working with coala and solves issue Set up static code analysis #12