no output at all for inputs under 10.

➜  codesample git:(master) python roman.py 1

➜  codesample git:(master) python roman.py 2

➜  codesample git:(master) python roman.py 3

➜  codesample git:(master) python roman.py 4

➜  codesample git:(master) python roman.py 5

➜  codesample git:(master) python roman.py 6

➜  codesample git:(master) python roman.py 7

➜  codesample git:(master) python roman.py 8

➜  codesample git:(master) python roman.py 9

➜  codesample git:(master) python roman.py 10
X

not sure if the problem is with the get_largest_base or get_roman_digit function. i didn't really dig. unittests will help you catch stuff like this in the future

don't really like how the get_roman_digit prints as it goes. you should probably have it return the value and print it in main

Suggest what unit tests I should do. Not sure how it could be done when the program is recursive.

Once you switch the central function to return value instead of print, you
just test equality

Assert that get_roman_digit(x) == y

For a comprehensive set of input/output
On Apr 13, 2016 13:56, "yiwork" [email protected] wrote:

Suggest what unit tests I should do. Not sure how it could be done when
the program is recursive.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1 (comment)