Include unique file only once#599
Merged
brentleyjones merged 1 commit intoyonaskolb:masterfrom Aug 19, 2019
Merged
Conversation
Contributor
Author
|
@nivanchikov, could you test this PR against your case from the #577 |
Closed
Contributor
Author
|
@yonaskolb done, but #574 is a separate issue and out of scope |
Owner
|
Thanks @haritowa, still need a changelog entry before this can be merged |
Contributor
|
@haritowa can you please add a changelog (if you haven't already)? Would be awesome to get this PR merged |
brentleyjones
approved these changes
Aug 19, 2019
Collaborator
brentleyjones
left a comment
brentleyjones
left a comment
There was a problem hiding this comment.
This now has a changelog. Approving so I can merge it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #574
Closes #577