fix(android): Setting String Value to Width And Height#10668
Open
db-r-hashimoto wants to merge 2 commits intoNativeScript:mainfrom
Open
fix(android): Setting String Value to Width And Height#10668db-r-hashimoto wants to merge 2 commits intoNativeScript:mainfrom
db-r-hashimoto wants to merge 2 commits intoNativeScript:mainfrom
Conversation
Contributor
|
Let me point out that this looks like a requested feature. Few things to point out:
|
Author
|
@CatchABus Strings should use single quotes, as per the coding conventions outlined here. I'll fix it accordingly. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently, when a string value is assigned to the width or height property of ImageAssetOptions, an error occurs on Android. This issue prevents users from specifying these properties as strings, which can be problematic in scenarios where string-based dimensions are used.
What is the new behavior?
With this update, assigning a string value to the width or height property of ImageAssetOptions no longer results in an error on Android. The system now properly handles string-based dimensions, providing a more flexible and consistent experience for users.
Fixes/Implements/Closes #6289 .