ref(core): MediaQueryList module improvements#10947
Open
CatchABus wants to merge 12 commits intoNativeScript:mainfrom
Open
ref(core): MediaQueryList module improvements#10947CatchABus wants to merge 12 commits intoNativeScript:mainfrom
CatchABus wants to merge 12 commits intoNativeScript:mainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 2f28a28
☁️ Nx Cloud last updated this comment at |
CatchABus
force-pushed
the
ref/media-query-list
branch
from
f22367b to
2b827f6
Compare
NathanWalker
approved these changes
Nov 18, 2025
CatchABus
commented
Nov 19, 2025
| @@ -0,0 +1,23 @@ | |||
| export const ApplicationEventNames = Object.freeze({ | |||
Contributor
Author
There was a problem hiding this comment.
@NathanWalker I forgot to mention this but I put application event names into their own separate module and Application instance accesses them using getters.
At the same time, Application implements the type of the ApplicationEventNames to ensure that no getter is accidentally missed.
If this change looks ugly, we can definitely revert it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
MediaQueryList implementation was a bit poorly written due to the media queries implementation being too large of a change.
What is the new behavior?
This PR gives some attention to
MediaQueryList.