refactor(platform-browser): update Meta and Title services to use inject #66968
+36
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the Meta and Title services to use the `inject` function for retrieving the `DOCUMENT` token. Also update the SharedStylesHost test to use DI.
SkyZeroZx
force-pushed
the
refactor/meta-title-to-inject
branch
from
e968257 to
0884427
Compare
JeanMeche
added
the
action: global presubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the Meta and Title services to use the
injectfunction for retrieving theDOCUMENTtoken.Also update the SharedStylesHost test to use DI.
Does this PR introduce a breaking change?
Other information
This shouldn't introduce any breaking changes since we consider them final classes, although I don't know their status within G3
Additionally, I updated the tests for using DI.