Skip to content

refactor(devtools): Add a new childSignalProp DebugSignalGraphNode kind t… #67009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
csmick wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(devtools): Add a new childSignalProp DebugSignalGraphNode kind t… #67009

csmick wants to merge 1 commit into from
+34 −3

Conversation

@csmick
Copy link

@csmick csmick commented Feb 11, 2026

…o represent a signal being passed to a child component as a prop.

The purpose for this change is to add nodes to the signal graph to make it clear when producer nodes, especially those that aren't consumed in the component being inspected, are passed to child components for consumption.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Various DebugSignalGraphNode kinds exist to represent signals, computeds, effects, and others in the signal graph.

Issue Number: N/A

What is the new behavior?

A new childSignalProp DebugSignalGraphNode kind is being added.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from hawkgs February 11, 2026 00:17
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: devtools labels Feb 11, 2026
@ngbot ngbot bot added this to the Backlog milestone Feb 11, 2026
@hawkgs
Copy link
Member

hawkgs commented Feb 11, 2026

@csmick, would you be able to rename the commit to refactor(devtools): ... instead?

I know it's a bit confusing to name it a refactor, but feat(devtools) commits are picked for the version change log for the web stores, so we try to limit its usage to larger features that make sense to the end users.

Other than that, LGTM!

@csmick csmick changed the title feat(devtools): Add a new childSignalProp DebugSignalGraphNode kind t… refactor(devtools): Add a new childSignalProp DebugSignalGraphNode kind t… Feb 11, 2026
@csmick
Copy link
Author

csmick commented Feb 11, 2026

@csmick, would you be able to rename the commit to refactor(devtools): ... instead?

I know it's a bit confusing to name it a refactor, but feat(devtools) commits are picked for the version change log for the web stores, so we try to limit its usage to larger features that make sense to the end users.

Other than that, LGTM!

Done!

@dgp1130 dgp1130 self-requested a review February 11, 2026 18:29
@dgp1130 dgp1130 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Feb 12, 2026
dgp1130
dgp1130 approved these changes Feb 12, 2026
View reviewed changes
Copy link
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only suggestion from me is to leave a comment somewhere describing what this node represents in Wiz, since it might be hard for future readers to understand the context, especially when it won't appear elsewhere in the Angular codebase.

When you're ready, let me know and I can slap the action: merge label on to get this merged into the repo.

@csmick
refactor(devtools): Add a new childSignalProp DebugSignalGraphNode ki…
a347937 
…nd to represent a signal being passed to a child component as a prop.

The purpose for this change is to add nodes to the signal graph to make it clear when producer nodes, especially those that aren't consumed in the component being inspected, are passed to child components for consumption.
@csmick
Copy link
Author

csmick commented Feb 12, 2026

LGTM, only suggestion from me is to leave a comment somewhere describing what this node represents in Wiz, since it might be hard for future readers to understand the context, especially when it won't appear elsewhere in the Angular codebase.

When you're ready, let me know and I can slap the action: merge label on to get this merged into the repo.

Added a comment to messages.ts. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgp1130 dgp1130 dgp1130 approved these changes

@hawkgs hawkgs Awaiting requested review from hawkgs

Assignees

No one assigned

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: devtools detected: feature PR contains a feature commit target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@csmick @hawkgs @dgp1130