[pyupgrade] Ignore is_typeddict and TypedDict for deprecated-import (UP035)#15800
Merged
AlexWaygood merged 2 commits intoastral-sh:mainfrom Jan 29, 2025
Merged
[pyupgrade] Ignore is_typeddict and TypedDict for deprecated-import (UP035)#15800AlexWaygood merged 2 commits intoastral-sh:mainfrom
pyupgrade] Ignore is_typeddict and TypedDict for deprecated-import (UP035)#15800AlexWaygood merged 2 commits intoastral-sh:mainfrom
Conversation
Contributor
|
AlexWaygood
reviewed
Jan 29, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! Could you also move "TypedDict" out of the TYPING_EXTENSIONS_TO_TYPING_313 list? Even on Python 3.13, typing_extensions.TypedDict is different to typing.TypedDict in the latest release of typing_extensions. (It provides an implementation of a version of PEP 728, which hasn't yet been accepted, and therefore hasn't yet been incorporated into typing.TypedDict)
InSyncWithFoo
changed the title
pyupgrade] Ignore is_typeddict (UP035)pyupgrade] Ignore is_typeddict and TypedDict (UP035)
AlexWaygood
changed the title
pyupgrade] Ignore is_typeddict and TypedDict (UP035)pyupgrade] Ignore is_typeddict and TypedDict for deprecated-import (UP035)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #15780.
is_typeddictandTypedDictare now listed as known exceptions to the rule. The former will presumably stay until 3.9 reaches its end-of-life circa this October.Test Plan
cargo nextest runandcargo insta test.