Store params and parsed params into deployment payload#325
Merged
GrantBirki merged 9 commits intogithub:mainfrom Nov 28, 2024
Merged
Store params and parsed params into deployment payload#325GrantBirki merged 9 commits intogithub:mainfrom
GrantBirki merged 9 commits intogithub:mainfrom
Conversation
…ute its value once
GrantBirki
approved these changes
Nov 28, 2024
Contributor
GrantBirki
left a comment
There was a problem hiding this comment.
@fabn thank you again for another great contribution! I have reviewed these changes and pushed a few commits to improve unit tests, add documentation, and make it so that we only ever have to parse the params once. I'll get these changes merged in for you today so that you can test them out. I'll plan on making a new release containing these changes next week. 🚀
Contributor
Author
|
Thank you for your prompt reaction 💪🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #322, the use case is the following: when creating a deployment one could use passed params to customise the deployment process (e.g. to pass terraform variables, or set some custom ENV variables in a kubernetes deployment).
Some environments needs to be update whenever their source branch is updated without need to trigger another deployment from scratch.
With this PR it's possible to inspect the previous deployment object and get creation params and update the environment reusing the same creation flags, proof of concept (not tested but it should work):