Add JSpecify annotations to 10 classes in graphql.execution package #4225

Copilot · 2026-01-25T06:37:25Z

Annotates 10 classes in graphql.execution package with JSpecify nullability markers, following the established pattern in the codebase.

Annotated Classes

ResultNodesInfo
ResultPath - nullable parent/segment fields, nullable returns for getParent() and dropSegment()
SimpleDataFetcherExceptionHandler
SubscriptionExecutionStrategy - nullable return for mkReactivePublisher()
UnknownOperationException - nullable return for getLocations()
UnresolvedTypeException
conditional.ConditionalNodeDecision
directives.QueryAppliedDirective - nullable definition field
directives.QueryAppliedDirectiveArgument - nullable definition field, nullable generic return for getValue()
directives.QueryDirectives

Implementation

Applied @NullMarked at class/interface level
Marked Builder inner classes with @NullUnmarked
Added @Nullable annotations to nullable fields and return types
Removed redundant @NonNull annotations (now implicit under @NullMarked)
Added assertNotNull guards in ResultPath and SubscriptionExecutionStrategy for NullAway compliance
Removed classes from exemption list in JSpecifyAnnotationsCheck.groovy

Example

@PublicApi
@NullMarked
public class ResultPath {
    private final @Nullable ResultPath parent;
    private final @Nullable Object segment;
    
    public @Nullable ResultPath dropSegment() {
        if (this == rootPath()) {
            return null;
        }
        return this.parent;
    }
    
    @NullUnmarked
    public static class Builder {
        // Builder doesn't require null annotations
    }
}

Original prompt

Task

Add JSpecify annotations to the following 10 classes in the graphql.execution package and subpackages, following the established JSpecify annotation pattern documented in .claude/commands/jspecify-annotate.md.

Classes to annotate

graphql.execution.ResultNodesInfo

graphql.execution.ResultPath

graphql.execution.SimpleDataFetcherExceptionHandler

graphql.execution.SubscriptionExecutionStrategy

graphql.execution.UnknownOperationException

graphql.execution.UnresolvedTypeException

graphql.execution.conditional.ConditionalNodeDecision

graphql.execution.directives.QueryAppliedDirective

graphql.execution.directives.QueryAppliedDirectiveArgument

graphql.execution.directives.QueryDirectives

Instructions

Follow the JSpecify annotation process documented in .claude/commands/jspecify-annotate.md:

Set each class to be @NullMarked at the class level

Remove all redundant @NonNull annotations that IntelliJ may have added

Check Javadoc for @param tags mentioning "null", "nullable", "may be null"

Check Javadoc @return tags mentioning "null", "optional", "if available"

Inspect method implementations that return null or check for null

Consider GraphQL specification details when determining nullability

For Builder static classes, label them @NullUnmarked and no further annotations needed

Validation

After making changes, run the NullAway compile check:
./gradlew compileJava
If you find NullAway errors, make the smallest possible change to fix them. You can use assertNotNull with a message if needed.

Cleanup

Remove each completed class from the exemption list in src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy

Delete all unused imports from the classes you've annotated

Do not make spacing or formatting changes - only make minimal changes necessary for the annotations

Reference

Look at existing annotated classes in the repository for reference patterns.

This pull request was created from Copilot chat.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

# Conflicts: # src/main/java/graphql/relay/DefaultConnectionCursor.java # src/main/java/graphql/relay/DefaultEdge.java # src/main/java/graphql/relay/SimpleListConnection.java

Co-authored-by: dondonz <[email protected]>

dondonz · 2026-01-25T09:41:23Z

src/main/java/graphql/execution/ResultPath.java

            return this;
        }
-        return parent;
+        return assertNotNull(parent, "parent should not be null for non-root path");


TODO: check this

dondonz · 2026-01-25T09:41:49Z

src/main/java/graphql/execution/ResultPath.java


    public String getSegmentName() {
-        return (String) segment;
+        return (String) assertNotNull(segment, "segment should not be null");


TODO: check if we want these asserts here

dondonz · 2026-01-25T09:42:38Z

src/main/java/graphql/execution/ResultPath.java

        }

-        return self.isRootPath() && that.isRootPath();
+        return (self == null || self.isRootPath()) && (that == null || that.isRootPath());


TODO: double check this change in return statement

dondonz added 30 commits August 21, 2025 19:23

Annotate GraphQLAppliedDirective

1b01d2b

Add GraphQLSchema annotation

8684b48

Remove exemption

0cdc8de

Annotate GraphQLType and GraphQLEnumType

30d0abe

Add Nullmarked to GraphQLEnumType

6ee01b8

Annotate GraphQLCodeRegistry

a45c613

Annotate GraphQLList

70336d5

Annotate PropertyDataFetcher

29f8363

Annotate GraphQLUnionType

083b2ab

Tidy up

b4761ef

Annotate GraphQLScalarType

9a78fb3

Annotate GraphQLNamedInputType

7bbfd9c

Add ErrorType

7427f64

Annotate Directives

120095c

Annotate ErrorClassification

012f49c

Annotate ExceptionWhileDataFetching

afdd408

Annotate ExecutionResult

803c924

Annotate GraphQLContext

a322ed0

Annotate AssertException and GraphQLError

41320d4

Annotate GraphQLErrorBuilder

9765c21

Annotate GraphQLErrorException

0ee713c

Annotate ParseAndValidate

e54fca2

Annotate ParseAndValidateResult

603c00d

Annotate Scalars

9fcaea1

Annotate SerializationError

88b02f3

Update GraphQLError with a nullable location list

e65217c

Annotate TypeMismatchError

19000a5

Annotate UnresolvedTypeError

313bf4f

Remove agent as no longer exists

0846c55

Add JSpecify prompt

d2d87cd

dondonz and others added 18 commits September 1, 2025 14:11

Annotate Anonymizer

23afaea

Merge branch 'master' into infer-nullity-3

bd2bd8d

# Conflicts: # src/main/java/graphql/relay/DefaultConnectionCursor.java # src/main/java/graphql/relay/DefaultEdge.java # src/main/java/graphql/relay/SimpleListConnection.java

Use string literal optimisation for assert

09a5236

Tidy up

d1e2e54

Make path length not nullable

95e7dc9

Use string literal for assert messages

f8920d8

Change GraphQL error message to be non-nullable

c78124c

Improve prompt

5b7104e

Add clarification on generics type arguments

de00e30

Merge branch 'master' into infer-nullity-3

e27bf54

Make TypeResolutionEnvironment value nullable

d5de341

Annotate TypeResolutionParameters

0496a3d

Add Nullmarked to TypeResolutionParameters

d2983da

Add prompt to reduce whitespace diff

92b3ac1

Initial plan

c60fdf6

Add JSpecify annotations to 10 classes in graphql.language package

c02fa4e

Co-authored-by: dondonz <[email protected]>

Update JSpecify annotation prompt with effectiveness improvements

3db2dde

Co-authored-by: dondonz <[email protected]>

Initial plan

00da46a

Copilot AI assigned Copilot and dondonz Jan 25, 2026

Copilot started work on behalf of dondonz January 25, 2026 07:18 View session

Add JSpecify annotations to 10 classes in graphql.execution package

e395eab

Co-authored-by: dondonz <[email protected]>

Copilot AI changed the title ~~[WIP] Add JSpecify annotations to classes in graphql.execution~~ Add JSpecify annotations to 10 classes in graphql.execution package Jan 25, 2026

Copilot AI requested a review from dondonz January 25, 2026 07:39

Copilot finished work on behalf of dondonz January 25, 2026 07:39

dondonz reviewed Jan 25, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 28, 2026

Review all open JSpecify PRs #4231

Draft

dondonz changed the base branch from copilot/add-jspecify-annotations-to-classes to master February 8, 2026 07:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JSpecify annotations to 10 classes in graphql.execution package #4225

Add JSpecify annotations to 10 classes in graphql.execution package #4225

Copilot AI commented Jan 25, 2026 •

edited

Loading

Uh oh!

dondonz Jan 25, 2026

Uh oh!

dondonz Jan 25, 2026

Uh oh!

dondonz Jan 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add JSpecify annotations to 10 classes in graphql.execution package #4225

Are you sure you want to change the base?

Add JSpecify annotations to 10 classes in graphql.execution package #4225

Conversation

Copilot AI commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Annotated Classes

Implementation

Example

Task

Classes to annotate

Instructions

Validation

Cleanup

Reference

Uh oh!

dondonz Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

dondonz Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

dondonz Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 25, 2026 •

edited

Loading