Don't leave space for property access on non-integer literals#50703
Merged
jakebailey merged 1 commit intomicrosoft:mainfrom Sep 9, 2022
Merged
Don't leave space for property access on non-integer literals#50703jakebailey merged 1 commit intomicrosoft:mainfrom
jakebailey merged 1 commit intomicrosoft:mainfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #50686
My fix was too overzealous; we shouldn't change our behavior when removing the space is still syntactically valid. My previous PR left the space in for an expression like
1.2.toString().Whether or not that is nicely formatted code is debatable, but I didn't intend to introduce a space for that expression in #50695.