Pick correct compilerOptions when checking if we can share emitSignatures#50910
Merged
sheetalkamat merged 3 commits intomainfrom Sep 28, 2022
Merged
Pick correct compilerOptions when checking if we can share emitSignatures#50910sheetalkamat merged 3 commits intomainfrom
sheetalkamat merged 3 commits intomainfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OldCompilerOptions is set only if referencemaps are created vs not created.
Module.Nonedoes not create reference map but other values do create it. Which is what determines if we can say copy semantic diagnostics etc..But emit signatures are purely based on declaration path and their contents so they should only use the compilerOptions directly from old state.
Fixes #50902