Remove some unnecessary code discovered by rollup#51204
Merged
jakebailey merged 1 commit intomicrosoft:mainfrom Oct 17, 2022
Merged
Remove some unnecessary code discovered by rollup#51204jakebailey merged 1 commit intomicrosoft:mainfrom
jakebailey merged 1 commit intomicrosoft:mainfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the module branch, I enabled the "smallest" preset of Rollup to see what it'd do; it deleted a block of code, which appears to do nothing after the code that used
reportErrorwas removed in #8485. Rollup's static analysis appears to have understood that. Neat.