Conversation
hipstersmoothie
added
the
patch:yes
hipstersmoothie
requested review from
alexandrebodin,
alterx,
leonrodenburg and
theinterned
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-types.storybook.now.sh |
hipstersmoothie
changed the title
Contributor
Member
|
@kroeder @gaetanmaisse @emilio-martinez can one of you take a look at this? |
emilio-martinez
approved these changes
Sep 20, 2019
Contributor
emilio-martinez
left a comment
emilio-martinez
left a comment
There was a problem hiding this comment.
Looks good to me. The DefinitelyTyped repo seems to follow a similar practice when establishing dependencies between types that depend on other package's types.
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Oct 7, 2019
This was referenced Oct 17, 2019
Merged
Merged
Merged
[Snyk] Upgrade @storybook/addon-actions from 5.2.1 to 5.2.3
GrabarzUndPartner/gp-vue-boilerplate#271
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: fixes #8105
What I did
Move types for
react-colorto deps since those types end up in the build output and are requiredHow to test
If your answer is yes to any of these, please make sure to include it in your PR.