The Wayback Machine - https://web.archive.org/web/20190322181110/https://github.com/angular/angular/pull/27979
Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove remaining travis leftovers #27979

Closed
wants to merge 2 commits into
base: master
from
+28 −134

Conversation

Reviewers

@IgorMinar IgorMinar

@gkalpak gkalpak

@angular/fw-testing fw-testing

Assignees
No one assigned
Labels
PR action: merge PR target: master & patch cla: yes comp: build & ci
Projects
None yet
Milestone
  needsTriage
6 participants
@devversion @mary-poppins @IgorMinar @ocombe @gkalpak @googlebot
@devversion
Copy link
Member

devversion commented Jan 8, 2019 •
edited

  • There still seem to be a few TravisCI leftovers which can be removed now.
  • Also fixes that a few e2e tests aren't running. These have been disabled a long time ago, but can be re-enabled now.

@devversion devversion added the PR state: WIP label Jan 8, 2019

@devversion devversion requested review from IgorMinar and angular/docs-infra as code owners Jan 8, 2019

@googlebot googlebot added the cla: yes label Jan 8, 2019

@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Jan 8, 2019

You can preview 5f4ef73 at https://pr27979-5f4ef73.ngbuilds.io/.

@devversion devversion force-pushed the devversion:chore/remove-travis-leftovers branch from 4d73686 to f4d4e7b Jan 8, 2019

@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Jan 8, 2019

You can preview f4d4e7b at https://pr27979-f4d4e7b.ngbuilds.io/.

devversion added some commits Jan 8, 2019

@devversion
build: remove travisci leftovers
Loading status checks…
aba7d75
@devversion
build: re-enable disabled e2e tests 
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.
Loading status checks…
f335215

@devversion devversion force-pushed the devversion:chore/remove-travis-leftovers branch from f4d4e7b to f335215 Jan 8, 2019

@devversion devversion added PR target: master & patch PR action: review comp: build & ci and removed PR state: WIP labels Jan 8, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 8, 2019

@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Jan 8, 2019

You can preview f335215 at https://pr27979-f335215.ngbuilds.io/.
@gkalpak

gkalpak approved these changes Jan 8, 2019
View changes

@IgorMinar

IgorMinar approved these changes Jan 9, 2019
View changes

Copy link
Member

IgorMinar left a comment

thanks!
@IgorMinar

This comment has been minimized.

Sign in to view
Copy link
Member

IgorMinar commented Jan 9, 2019

http://test/OCL:228478868:BASE:228478898:1547027617834:a494b147

@IgorMinar IgorMinar added PR action: merge PR action: merge-assistance and removed PR action: review labels Jan 9, 2019

@IgorMinar

This comment has been minimized.

Sign in to view
Copy link
Member

IgorMinar commented Jan 9, 2019

caretaker note: pending review check is invalid because the PR has global approver approval

@ocombe this is a good example of when robot should not complain about pending reviews.

@ocombe ocombe added PR action: merge-assistance and removed PR action: merge-assistance labels Jan 9, 2019

@ocombe ocombe added PR action: merge-assistance PR target: master & patch and removed PR action: merge-assistance PR target: master & patch labels Jan 9, 2019

@ocombe

This comment has been minimized.

Sign in to view
Copy link
Contributor

ocombe commented Jan 9, 2019

I removed the merge-assistance label as the bot is now able to ignore team review requests.

AndrewKushnir added a commit that referenced this pull request Jan 9, 2019

@devversion @AndrewKushnir
build: remove travisci leftovers (#27979) 
PR Close #27979
Loading status checks…
e0ed78c

AndrewKushnir added a commit that referenced this pull request Jan 9, 2019

@devversion @AndrewKushnir
build: re-enable disabled e2e tests (#27979) 
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979
Loading status checks…
84857a2

@AndrewKushnir AndrewKushnir closed this in c7d1890 Jan 9, 2019

AndrewKushnir added a commit that referenced this pull request Jan 9, 2019

@devversion @AndrewKushnir
build: re-enable disabled e2e tests (#27979) 
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979
Loading status checks…
31fdff7

AndrewKushnir added a commit that referenced this pull request Jan 16, 2019

@devversion @AndrewKushnir
build: remove travisci leftovers (#27979) 
PR Close #27979
Loading status checks…
11728bb

AndrewKushnir added a commit that referenced this pull request Jan 16, 2019

@devversion @AndrewKushnir
build: re-enable disabled e2e tests (#27979) 
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979
Loading status checks…
bea6771

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

@devversion @ngfelixl
build: remove travisci leftovers (angular#27979) 
PR Close angular#27979
2c60e79

ngfelixl added a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

@devversion @ngfelixl
build: re-enable disabled e2e tests (angular#27979) 
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close angular#27979
7fcabbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.