The Wayback Machine - https://web.archive.org/web/20201114115639/https://github.com/letsencrypt/boulder/pull/1830
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Travis tests in Docker #1830

Merged
merged 63 commits into from May 19, 2016
Merged

Run Travis tests in Docker #1830

merged 63 commits into from May 19, 2016

Conversation

@jsha
Copy link
Contributor

@jsha jsha commented May 18, 2016

  • Create a base Docker image containing the tools we normally download as part of a Travis run. This cuts build times a lot, mainly because we don't need to build protoc from source.
  • Set necessary environment variables
  • Switch to MariaDB 10.1, including necessary changes to DB creation scripts.
  • Tweak reloader_test so it passes when run as root on Docker
  • Use prebuilt letsencrypt package from jessie-backports, instead of building the most recent one. Note that we still have to clone the certbot repo to get the test scripts, but we don't have to build and install dependencies like augeas. Note that jessie-backports does not yet have certbot. Once it does, we'll switch to that.
  • ct-test-srv and mail-test-srv listen on 0.0.0.0
  • Use prebuilt rabbitmq-setup in entrypoint.sh, which greatly speeds up repeated docker run commands.

Fixes #1335

@rolandshoemaker
Copy link
Contributor

@rolandshoemaker rolandshoemaker commented May 19, 2016

26 min -> 17 min run time! LGTM.

@@ -16,7 +16,7 @@ import (
blog "github.com/letsencrypt/boulder/log"
)

var apiPort = flag.String("http", "9381", "http port to listen on")
var listenAPI = flag.String("http", "0.0.0.0:9381", "http port to listen on")

This comment has been minimized.

@riking

riking May 19, 2016
Contributor

note: there is no code in the integration test using this flag, so this is OK

@riking riking added the r=riking label May 19, 2016
@riking riking merged commit 92d94f2 into master May 19, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jsha added a commit that referenced this pull request May 20, 2016
This reverts commit 92d94f2.

That commit breaks the build.
jsha added a commit that referenced this pull request May 20, 2016
This reverts commit 92d94f2 and commit 0b4623f to unbreak the Certbot build.
cpu added a commit to cpu/boulder that referenced this pull request May 23, 2016
jsha added a commit that referenced this pull request May 23, 2016
jsha added a commit that referenced this pull request May 24, 2016
Do not merge until certbot/certbot#3058 lands.

That change broke the certbot tests because it switched to a MariaDB
10.1-specific syntax. certbot/certbot#3058 changes the certbot tests to use
Boulder's docker-compose.yml, so they will get MariaDB 10.1 automatically.
jsha added a commit to jsha/boulder that referenced this pull request May 24, 2016
Do not merge until certbot/certbot#3058 lands.

That change broke the certbot tests because it switched to a MariaDB
10.1-specific syntax. certbot/certbot#3058 changes the certbot tests to use
Boulder's docker-compose.yml, so they will get MariaDB 10.1 automatically.
jsha added a commit that referenced this pull request May 24, 2016
That change broke the certbot tests because it switched to a MariaDB
10.1-specific syntax. certbot/certbot#3058 changes the certbot tests to use
Boulder's docker-compose.yml, so they will get MariaDB 10.1 automatically.
@cpu cpu deleted the test-docker-maria101 branch Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.