The Wayback Machine - https://web.archive.org/web/20201114121820/https://github.com/letsencrypt/boulder/pull/4114
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TLS-SNI-01 #4114

Merged
merged 4 commits into from Mar 15, 2019
Merged

Remove TLS-SNI-01 #4114

merged 4 commits into from Mar 15, 2019

Conversation

@jsha
Copy link
Contributor

@jsha jsha commented Mar 14, 2019

  • Remove the challenge whitelist
  • Reduce the signature for ChallengesFor and ChallengeTypeEnabled
  • Some unit tests in the VA were changed from testing TLS-SNI to testing the same behavior in TLS-ALPN, when that behavior wasn't already tested. For instance timeouts during connect are now tested.

Fixes #4109

@jsha jsha requested a review from letsencrypt/boulder-developers as a code owner Mar 14, 2019
sa/model.go Outdated Show resolved Hide resolved
sa/sa_test.go Outdated Show resolved Hide resolved
@rolandshoemaker
Copy link
Contributor

@rolandshoemaker rolandshoemaker commented Mar 14, 2019

TLSSNIRevalidation should probably also be moved to the deprecated features section of features.go.

@cpu
cpu approved these changes Mar 15, 2019
Copy link
Contributor

@cpu cpu left a comment

This is great, thanks @jsha !

@cpu cpu merged commit d1e6d0f into master Mar 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cpu cpu deleted the rm-tls-sni branch Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.