The Wayback Machine - https://web.archive.org/web/20190322180519/https://github.com/codercom/code-server/pull/245
Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more

/code-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install from VSIX for TAR and ZIP formats #245

Merged
merged 2 commits into from Mar 21, 2019
+215 −114

Conversation

Reviewers

@NGTmeaty NGTmeaty

@kylecarbs kylecarbs

@code-asher code-asher

Assignees

@foresthoffman foresthoffman

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@foresthoffman @NGTmeaty @kylecarbs
@foresthoffman
Copy link
Collaborator

foresthoffman commented Mar 14, 2019

Describe in detail the problem you had and how this PR fixes it

Fixes installing extensions from VSIX files formatted as either TAR or ZIP.

Is there an open issue you can link to?

Fixes #92

@foresthoffman foresthoffman self-assigned this Mar 14, 2019

@foresthoffman foresthoffman requested review from code-asher and kylecarbs as code owners Mar 14, 2019

@NGTmeaty

NGTmeaty approved these changes Mar 17, 2019
View changes

Copy link

NGTmeaty left a comment

LGTM!

@NGTmeaty NGTmeaty referenced this pull request Mar 17, 2019

Open

Add note about extensions needing to be OSS #113

@kylecarbs

kylecarbs reviewed Mar 20, 2019
View changes

Show resolved Hide resolved packages/vscode/src/fill/zip.ts Outdated

@foresthoffman foresthoffman requested a review from kylecarbs Mar 20, 2019

@foresthoffman foresthoffman referenced this pull request Mar 21, 2019

Open

Add folder to workspace results in grey screen #309

@kylecarbs kylecarbs merged commit 18f395b into codercom:master Mar 21, 2019

zerdos added a commit to zerdos/code-server that referenced this pull request Mar 22, 2019

@zerdos
Docker (#6) 
* Fix debugging

* update nginx config (codercom#288)

should add one line `proxy_set_header Accept-Encoding gzip; `  or you may get a  `Cannot GET /` error.

* Update codeowners

* Fixes codercom#275

* doc: add CrOS install guide (codercom#225)

* doc: add CrOS install guide

Signed-off-by: Hikari <[email protected]>

* doc: change occurences of index to install guide

Signed-off-by: Hikari <[email protected]>

* doc: add penguin.linux.test as alternative endpoint

Signed-off-by: Hikari <[email protected]>

* doc: link Crostini and crouton info pages and describe install guide

Signed-off-by: Hikari <[email protected]>

* doc: remove citations for dev mode requirement

Signed-off-by: Hikari <[email protected]>

* doc: clarify more wording

Signed-off-by: Hikari <[email protected]>

* doc: fix typo in Crostini section

Signed-off-by: Hikari <[email protected]>

* Capitalized first letters to be consistent (codercom#304)

In addition to capitalizing, I also reworded a sentence for improved grammar.

* Update index.md (codercom#297)

Added Apache reverse proxy example configuration

* Fix install from VSIX for TAR and ZIP formats (codercom#245)

* Fix install from VSIX for TAR and ZIP formats

* Parse TAR before ZIP, when installing from VSIX
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1dda715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.