The Wayback Machine - https://web.archive.org/web/20190322181058/https://github.com/angular/angular/pull/29417
Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cache Material `node_modules` based on the lockfile checksum #29417

Closed
wants to merge 1 commit into
base: master
from
+6 −6

Conversation

Reviewers

@filipesilva filipesilva

@devversion devversion

Assignees
No one assigned
Labels
PR action: merge PR target: master-only cla: yes comp: build & ci
Projects
None yet
Milestone
  needsTriage
5 participants
@gkalpak @googlebot @matsko @filipesilva @devversion
@gkalpak
Copy link
Member

gkalpak commented Mar 20, 2019 •
edited

This will increase the cache hit rate for the material-unit-tests job.

Builds on top of #29416.

@gkalpak gkalpak requested a review from angular/fw-dev-infra as a code owner Mar 20, 2019

@gkalpak gkalpak added PR action: merge comp: build & ci PR state: blocked PR target: master & patch labels Mar 20, 2019

@ngbot ngbot bot modified the milestone: needsTriage Mar 20, 2019

@googlebot

This comment has been minimized.

Sign in to view
Copy link

googlebot commented Mar 20, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Mar 20, 2019

@gkalpak gkalpak force-pushed the gkalpak:ci-cache-material-on-lockfile branch from bef05e2 to 5c787ce Mar 20, 2019

@devversion

devversion approved these changes Mar 20, 2019
View changes

@gkalpak gkalpak referenced this pull request Mar 20, 2019

Closed

ci: do not cache modified "node_modules" in "material-unit-tests" job #29416

@gkalpak gkalpak force-pushed the gkalpak:ci-cache-material-on-lockfile branch from 5c787ce to 4a0fad2 Mar 20, 2019

@gkalpak
ci: cache Material `node_modules` based on the lockfile checksum 
This will increase the cache hit rate for the `material-unit-tests` job.
Related to #29416 (comment).
Loading status checks…
e1dc671

@gkalpak gkalpak force-pushed the gkalpak:ci-cache-material-on-lockfile branch from 4a0fad2 to e1dc671 Mar 20, 2019

@googlebot

This comment has been minimized.

Sign in to view
Copy link

googlebot commented Mar 20, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 20, 2019

@filipesilva

filipesilva approved these changes Mar 20, 2019
View changes

@filipesilva filipesilva removed the PR state: blocked label Mar 20, 2019

@matsko matsko added PR target: master-only and removed PR target: master & patch labels Mar 20, 2019

@matsko

This comment has been minimized.

Sign in to view
Copy link
Member

matsko commented Mar 20, 2019

@gkalpak this fails on patch. Please open a new PR and target it directly to 7.2.x

@matsko matsko closed this in fd122b0 Mar 20, 2019

@gkalpak gkalpak deleted the gkalpak:ci-cache-material-on-lockfile branch Mar 20, 2019

@gkalpak

This comment has been minimized.

Sign in to view
Copy link
Member Author

gkalpak commented Mar 20, 2019

My bad. The material-unit-tests jobs does not exist on patch 😇
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.