The Wayback Machine - https://web.archive.org/web/20190322181057/https://github.com/angular/angular/pull/28273
Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update buildkite provision instructions #28273

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@alexeagle alexeagle

@gkalpak gkalpak

Assignees
No one assigned
Labels
PR action: merge PR target: master-only cla: yes comp: build & ci
Projects
None yet
Milestone
  needsTriage
6 participants
@filipesilva @mary-poppins @alexeagle @gkalpak @googlebot @jasonaden
@filipesilva
Copy link
Member

filipesilva commented Jan 21, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The provisioning script had a missing comma, and omitted the SSD recommendation.

What is the new behavior?

Updated provisioning script.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@filipesilva filipesilva requested a review from angular/fw-dev-infra as a code owner Jan 21, 2019

@googlebot googlebot added the cla: yes label Jan 21, 2019

@mary-poppins

This comment has been minimized.

Sign in to view
Copy link

mary-poppins commented Jan 21, 2019

You can preview 7a3f868 at https://pr28273-7a3f868.ngbuilds.io/.

@filipesilva filipesilva added the PR target: master-only label Jan 21, 2019

@filipesilva filipesilva requested a review from gkalpak Jan 21, 2019

@gkalpak

gkalpak reviewed Jan 21, 2019
View changes

packages/bazel/package.bzl Outdated
url = "https://github.com/bazelbuild/rules_nodejs/archive/0.16.5.zip",
strip_prefix = "rules_nodejs-0.16.5",
url = "https://github.com/bazelbuild/rules_nodejs/archive/1bcdd48ef7ce40974e85508a52afd3dc83b61b3d.zip",
strip_prefix = "rules_nodejs-1bcdd48ef7ce40974e85508a52afd3dc83b61b3d",

This comment has been minimized.

Sign in to view
Copy link
@gkalpak

gkalpak Jan 21, 2019

Member

AFAICT (based on this and that), bazelbuild/rules_nodejs@1bcdd48 is included in 0.16.5 😕

This comment has been minimized.

Sign in to view
Copy link
@filipesilva

filipesilva Jan 21, 2019

Author Member

Oh jeez, I misread the merge dates! You're totally right.

This comment has been minimized.

Sign in to view
Copy link
@filipesilva

filipesilva Jan 21, 2019

Author Member

Updated the PR to only include that provisioning change.

@filipesilva filipesilva force-pushed the filipesilva:update-buildkite-provision branch from 7a3f868 to 5959f5e Jan 21, 2019

@filipesilva filipesilva changed the title Update rules_nodejs to include node timeout fix update buildkite provision instructions Jan 21, 2019

@gkalpak

gkalpak approved these changes Jan 21, 2019
View changes

@jasonaden jasonaden added comp: docs comp: build & ci and removed comp: docs labels Jan 23, 2019

@ngbot ngbot bot added this to the needsTriage milestone Jan 24, 2019

@alexeagle

alexeagle approved these changes Feb 7, 2019
View changes

@alexeagle alexeagle added the PR action: merge label Feb 7, 2019

@mhevery mhevery closed this in 71fa1f2 Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.