The Wayback Machine - https://web.archive.org/web/20210119193739/https://github.com/realpython/python-guide/issues/913
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The image paths are changed #913

Open
charliedua opened this issue Aug 16, 2018 · 7 comments
Open

The image paths are changed #913

charliedua opened this issue Aug 16, 2018 · 7 comments

Comments

@charliedua
Copy link

@charliedua charliedua commented Aug 16, 2018

The folder which contains the images is moved resulting in the images not being shown, else a broken image is shown. Should we edit all the paths?

@charliedua charliedua changed the title the image paths are changed The image paths are changed Aug 16, 2018
@dbader
Copy link
Member

@dbader dbader commented Aug 16, 2018

Thanks @charliedua—which pages on https://docs.python-guide.org/ are affected?

@charliedua
Copy link
Author

@charliedua charliedua commented Aug 16, 2018

It is actually on GitHub rather than the website itself, the preview of the *.rst files contains wrong path to images.

@dbader
Copy link
Member

@dbader dbader commented Aug 16, 2018

Ah I see what you mean...yeah not sure if this is something we absolutely need to fix (as long as the website is ok) but I'd be open to a PR that resolves this.

@charliedua
Copy link
Author

@charliedua charliedua commented Aug 16, 2018

I can try to write a small python script which adds "/docs" before the "/_static" to all *.rst files eventually fixing the path. Yeah I can do that.

@dbader
Copy link
Member

@dbader dbader commented Aug 16, 2018

@charliedua That will break the live site. Fixing the GitHub preview for images seems more trouble than it's worth at this point IMO.

@charliedua
Copy link
Author

@charliedua charliedua commented Aug 17, 2018

Yeah, I understand.

Other Problem

I think it is not only affecting the images, its links as well, anyway I wrote a simple python script which fixes the image links and will upgrade it to fix the links as well.

Possible Fix

  • However if it is breaking the original site we can make a branch for people who read it on GitHub?
@dbader
Copy link
Member

@dbader dbader commented Aug 18, 2018

However if it is breaking the original site we can make a branch for people who read it on GitHub?

Mmh interesting idea but I don't have the bandwidth to maintain a parallel branch. Any solution you come up with would have to keep everything in one repo on one branch so we can use the same codebase on the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.