The Wayback Machine - https://web.archive.org/web/20191017141741/https://github.com/angular/angular/pull/32464
Skip to content

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language-service): add definitions for styleUrls #32464

Closed
wants to merge 3 commits into from

Conversation

@ayazhafiz
Copy link
Contributor

commented Sep 3, 2019

Adds support for styleUrls definitions in the same way templateUrl
definitions are provided; clicking on styleUrl will take a user to the
respective file.

Unifies some code in determining a URL definition. We first check if a
url is a templateUrl; if it's not, we check that it's a styleUrl or
return no definitions.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information
@ayazhafiz
feat(language-service): add definitions for styleUrls
Verified
This commit was signed with a verified signature.
ayazhafiz hafiz
GPG key ID: 3816BC20657C9B24 Learn about signing commits
Loading status checks…
2e02e94 
Adds support for `styleUrls` definitions in the same way `templateUrl`
definitions are provided; clicking on styleUrl will take a user to the
respective file.

Unifies some code in determining a URL definition. We first check if a
url is a `templateUrl`; if it's not, we check that it's a `styleUrl` or
return no definitions.
@ayazhafiz ayazhafiz requested a review from kyliau Sep 3, 2019
@ayazhafiz ayazhafiz requested review from angular/fw-integration as code owners Sep 3, 2019
@ayazhafiz ayazhafiz self-assigned this Sep 3, 2019
@ngbot ngbot bot modified the milestone: needsTriage Sep 3, 2019
@googlebot googlebot added the cla: yes label Sep 3, 2019
@ayazhafiz
fixup! feat(language-service): add definitions for styleUrls
Verified
This commit was signed with a verified signature.
ayazhafiz hafiz
GPG key ID: 3816BC20657C9B24 Learn about signing commits
Loading status checks…
93cd5cc
@ayazhafiz ayazhafiz requested a review from josephperrott Sep 6, 2019
@kyliau
kyliau requested changes Sep 6, 2019
View changes
integration/language_service_plugin/goldens/styleUrlsDefinition.json Outdated Show resolved Hide resolved
@ayazhafiz
fixup! feat(language-service): add definitions for styleUrls
Verified
This commit was signed with a verified signature.
ayazhafiz hafiz
GPG key ID: 3816BC20657C9B24 Learn about signing commits
Loading status checks…
f8f2429
@ngbot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 7, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_docs_examples" is failing
    pending missing required status "ci/circleci: publish_snapshot"
    pending 2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.
@kyliau

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 7, 2019

caretaker: failure in test_docs_examples is unrelated to this change.
@kyliau
kyliau approved these changes Sep 9, 2019
View changes
Copy link
Member

left a comment

LGTM, thank you!
@matsko matsko closed this in a391aeb Sep 9, 2019
@ayazhafiz ayazhafiz deleted the ayazhafiz:feat/style-urls branch Sep 9, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@ayazhafiz @arnehoek
feat(language-service): add definitions for styleUrls (angular#32464)
41a9001 
Adds support for `styleUrls` definitions in the same way `templateUrl`
definitions are provided; clicking on styleUrl will take a user to the
respective file.

Unifies some code in determining a URL definition. We first check if a
url is a `templateUrl`; if it's not, we check that it's a `styleUrl` or
return no definitions.

PR Close angular#32464
@angular-automatic-lock-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyliau kyliau

@angular/fw-integration fw-integration

@josephperrott josephperrott

Assignees

@ayazhafiz ayazhafiz

Labels
PR action: merge PR action: merge-assistance PR target: master-only cla: yes comp: language-service type: feature
Projects
None yet
Milestone
  needsTriage
3 participants
@ayazhafiz @kyliau @googlebot
You can’t perform that action at this time.