The Wayback Machine - https://web.archive.org/web/20220322102547/https://github.com/angular/angularfire/pull/2327
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schematics): support FIREBASE_TOKEN for ng deploy #2327

Merged
merged 8 commits into from Nov 11, 2020
Merged

feat(schematics): support FIREBASE_TOKEN for ng deploy #2327

merged 8 commits into from Nov 11, 2020

Conversation

IKatsuba
Copy link
Contributor

@IKatsuba IKatsuba commented Feb 13, 2020

Checklist

  • Issue number for this PR: #2138
  • Test units included?: yes
  • In a clean directory, yarn install, yarn test run successfully? yes

Description

Code sample

@IKatsuba IKatsuba requested a review from jamesdaniels Feb 13, 2020
@IKatsuba
Copy link
Contributor Author

@IKatsuba IKatsuba commented Mar 3, 2020

Any updates?

@IKatsuba
Copy link
Contributor Author

@IKatsuba IKatsuba commented Mar 21, 2020

@jamesdaniels hello! I really need this feature. Can you give comments on it?

@jamesdaniels jamesdaniels added this to the 6.0.0 milestone Mar 27, 2020
@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Mar 27, 2020

We'll get this in shortly, thanks for the contribution.

IKatsuba added 3 commits Mar 27, 2020
@IKatsuba
Merge remote-tracking branch 'origin/master' into firebase-token-from…
837e2e2 
…-env

# Conflicts:
#	src/schematics/deploy/actions.jasmine.ts
#	src/schematics/deploy/actions.ts
#	src/schematics/deploy/builder.ts
@IKatsuba
chore(schematics): corrections after incompatible conflict
27d64b0
@IKatsuba
Merge remote-tracking branch 'origin/master' into firebase-token-from…
a3435a9 
…-env
@wajeehmisbahkhan
Copy link

@wajeehmisbahkhan wajeehmisbahkhan commented Jun 8, 2020

Please provide updates on this or at least an alternative on how to use the firebase token in a CI environment. I tried deploying in Github Actions with

env:
  FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}

And I get:
Cannot run login in non-interactive mode. See login:ci to generate a token for use in non-interactive environments.

How do I set the environment variable so that it doesn't require a login?

@IKatsuba
Copy link
Contributor Author

@IKatsuba IKatsuba commented Jun 8, 2020

@wajeehmisbahkhan I tried to update the request, but the team never looked at it. Maybe @jamesdaniels have a different plan. Now I have no time to support this PR.

@jamesdaniels jamesdaniels removed this from the 6.0.0 milestone Jun 23, 2020
@jamesdaniels jamesdaniels added this to the 6.1 milestone Jun 23, 2020
@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Jun 23, 2020

I can take this to the finish line before I cut 6.1, thanks @IKatsuba

@IKatsuba
Copy link
Contributor Author

@IKatsuba IKatsuba commented Jun 27, 2020

@wajeehmisbahkhan you can try this package @ng-builders/firebase

@yasinkocak yasinkocak mentioned this pull request Jun 27, 2020
Closed
@jamesdaniels jamesdaniels merged commit dd92869 into angular:master Nov 11, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdaniels jamesdaniels

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
6.1
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@IKatsuba @jamesdaniels @wajeehmisbahkhan @googlebot