Fix query prepared empty array #191

maltrana · 2020-06-04T10:00:15Z

When we send a prepared_query with an empty array we get an error.

issue #190

To Reproduce
$db->query_prepared( 'select id from table' , []);

Expected behavior
Return result without errors

Environment:
EZSQL Version : 4.0.10
PHP Version: 7.3
SQL Driver: mysql

Changes:

if statment added in ez_mysqi.php
test added in mysqliTest.php

codecov-commenter · 2020-06-04T10:02:58Z

Codecov Report

Merging #191 into master will increase coverage by 0.00%.
The diff coverage is 93.75%.

@@            Coverage Diff            @@
##             master     #191   +/-   ##
=========================================
  Coverage     85.04%   85.05%           
- Complexity      809      811    +2     
=========================================
  Files            14       14           
  Lines          2033     2034    +1     
=========================================
+ Hits           1729     1730    +1     
  Misses          304      304

Impacted Files	Coverage Δ	Complexity Δ
lib/Database/ez_mysqli.php	`95.09% <93.75%> (+0.02%)`	`86.00 <0.00> (+2.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c843017...74e4b18. Read the comment docs.

techno-express · 2020-06-04T13:06:50Z

What's up with the spacing? Not PSR-2 in ez_mysqi.php modification.

maltrana · 2020-06-04T13:32:57Z

I'm sorry

Corrected.

maltrana added 2 commits Jun 4, 2020

Fixed query_prepared and test

4d497ff

Fixed query_prepared and test

Loading status checks…

d363179

Without Spaces

Loading status checks…

74e4b18

Oct	NOV	Dec
	09
2019	2020	2021

ezSQL / ezsql

Fix query prepared empty array #191

Fix query prepared empty array #191

maltrana commented Jun 4, 2020

codecov-commenter commented Jun 4, 2020 •

edited

techno-express commented Jun 4, 2020

maltrana commented Jun 4, 2020

ezSQL / ezsql

Join GitHub today

Fix query prepared empty array #191

Fix query prepared empty array #191

Conversation

maltrana commented Jun 4, 2020

codecov-commenter commented Jun 4, 2020 • edited

Codecov Report

techno-express commented Jun 4, 2020

maltrana commented Jun 4, 2020

Essential cookies

Always active

Analytics cookies

codecov-commenter commented Jun 4, 2020 •

edited