Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix code coverage of tests #1449
Comments
See issue nodegit#1449
I don't understand what you mean, @Croydon. If I look at nodegit/nodegit's build #3076 for instance, the tests appear to have been run. You can scroll to the bottom of a log file and see output from Mocha in it. |
|
Yes, These tests don't get execute in master currently: Line 93 in c2e8838 and they fail. |
|
Log of failure: https://travis-ci.org/inexorgame/nodegit/jobs/347256998#L9041 |
|
@JimiC My pull request already contains stages and they just bring in more structure. |
|
@Croydon Okay. I think what you mean is that the code coverage isn't being run, correct? |
|
Yes.And if someone can tell me what |
|
No. It fails when it runs. (And master never runs coverage tests, so this problem is hidden right now) I have fixed it within my pull requests, that coverages tests get executed when you switch the variable No regression in testing between master and my pull request. Fixing tests are a follow up task, therefore this issue. |
|
@Croydon Notice #1402 (comment) as we discussed that it may be prudent to build docs only on release for the moment. |
|
I think the last time code coverage for the C++ files were run was in Travis CI build #2741. We can see mention of this at the bottom of its log file.
This was then mistakenly "disabled" by 1269fd7 because the coverage tests were then set to run if |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Tests weren't run in the CI for some time. Therefore the failure of the tests were hidden.
I changed stuff in #1447 so they would get executed and disabled them temporary (in a visible, easy to switch way) due to the failure.
Eventually they should get fixed and enabled again.
https://travis-ci.org/inexorgame/nodegit/jobs/347256998#L9041