The Wayback Machine - https://web.archive.org/web/20201103161103/https://github.com/Azure/azure-rest-api-specs/issues/9847
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advisor Suppression Get API 404 #9847

Open
yupwei68 opened this issue Jun 16, 2020 · 1 comment
Open

Advisor Suppression Get API 404 #9847

yupwei68 opened this issue Jun 16, 2020 · 1 comment

Comments

@yupwei68
Copy link

@yupwei68 yupwei68 commented Jun 16, 2020

When getting an advisor suppression which doesn't exist, we get the following trace:

2020/06/16 10:11:46 [DEBUG] AzureRM Response for https://management.azure.com/%2Fsubscriptions%2F85b3dbca-5974-4067-9669-67a141095a76%2Fresourcegroups%2Fspinnakermanutest%2Fproviders%2Fmicrosoft.compute%2Fvirtualmachines%2Fspinmanutestvm/providers/Microsoft.Advisor/recommendations/179d68b9-08d9-efee-a930-b1a26cb4f537/suppressions/acctest-sp?api-version=2020-01-01:
HTTP/2.0 404 Not Found
Cache-Control: no-cache
Date: Tue, 16 Jun 2020 02:11:45 GMT
Expires: -1
Pragma: no-cache
Server: Microsoft-HTTPAPI/2.0
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Content-Type-Options: nosniff
X-Ms-Correlation-Request-Id: 148f0c91-5bdb-46a4-6892-2de5346b98cc
X-Ms-Ratelimit-Remaining-Subscription-Reads: 11999
X-Ms-Request-Id: 0c7287a8-559a-488f-ba0b-951d45264694
X-Ms-Routing-Request-Id: SOUTHEASTASIA:20200616T021145Z:0c7287a8-559a-488f-ba0b-951d45264694
Content-Length: 0

This response has raised error in Go SDK: StatusCode=404 -- Original Error: autorest/azure: error response cannot be parsed: "" error: EOF

We'd like to suggest to set a default in the response definition of Advisor Suppresion Get. And the error message suggests that the response body shall not be empty when 404. It would be better with some error message even when 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.