The Wayback Machine - https://web.archive.org/web/20220510185725/https://github.com/discordjs/discord.js/pull/3865
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update tests #3865

Merged
merged 6 commits into from Mar 7, 2020
Merged

test: update tests #3865

merged 6 commits into from Mar 7, 2020

Conversation

NotSugden
Copy link
Contributor

@NotSugden NotSugden commented Feb 29, 2020

Please describe the changes this PR makes and why it should be merged:
This PR updates the test files to use v12 methods instead of v11 methods

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • Haven't had time to test it all, but i believe it should work
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link
Contributor

@Jiralite Jiralite left a comment

Hey! Also, it seems that in the file random.js, lines 98 to 102 lack the .cache to access the Collection!

test/random.js Outdated Show resolved Hide resolved
@iCrawl iCrawl closed this Mar 1, 2020
@iCrawl iCrawl reopened this Mar 1, 2020
iCrawl
iCrawl approved these changes Mar 7, 2020
@iCrawl iCrawl merged commit 9b5f005 into discordjs:master Mar 7, 2020
3 checks passed
@NotSugden NotSugden deleted the test branch Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants