Implement stable sort #1072
Closed
Implement stable sort #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adrian17
reviewed
Jun 30, 2019
| @@ -0,0 +1,11 @@ | |||
| class Stable: | |||
Contributor
There was a problem hiding this comment.
We already have tests for sorting in tests/snippets/list.py - would be nice if they were in one place - either there or in the new file.
| let result = vm._lt(keys[i].clone(), keys[len - 1].clone())?; | ||
| let boolval = objbool::boolval(vm, result)?; | ||
| if boolval { | ||
| let eq = vm._eq(keys[i].clone(), keys[len - 1].clone())?; |
Contributor
There was a problem hiding this comment.
pretty sure CPython doesn't use __eq__, so this implementation may fail for classes that do stuff like
def __eq__(self, other): raise NotImplementedError
CPython's TimSort only uses __lt__ (and object identity comparisons)
Member
|
@sanxiyn would you be interested in fixing this up a bit so we can merge? It looks good and I think the code this touches hasn't changed that much in the ~5 months since this was opened (there aren't any merge conflicts, at least). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #578