The Wayback Machine - https://web.archive.org/web/20221005050402/https://github.com/python/cpython/pull/21475
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-32528: Document the change in inheritance of asyncio.CancelledError (GH-21474) #21475

Closed

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 14, 2020

GH-msg373510

bpo-32528/GH-13528 changed asyncio.CancelledError such that it no longer inherits from concurrent.futures.CancelledError. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist [email protected]

…or (pythonGH-21474)

GH-msg373510

[bpo-32528]()/pythonGH-13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist <[email protected]>
@miss-islington
Copy link
Contributor Author

miss-islington commented Jul 14, 2020

@JustAnotherArchivist: Status check is done, and it's a success .

Copy link
Member

@tirkarthi tirkarthi left a comment

LGTM. Thanks.

@miss-islington
Copy link
Contributor Author

miss-islington commented Jul 19, 2020

Sorry, I can't merge this PR. Reason: 3 of 4 required status checks are expected..

@tirkarthi tirkarthi closed this Jul 24, 2020
@miss-islington miss-islington deleted the backport-2a51818-3.9 branch Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants