Refactor doctor #12264
Refactor doctor #12264
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
|
so fare so good - I think with this refactor maintaining doctor is easyer ... EDIT: just noticed some unrelated enhancements at the logger... |
|
They're not quite unrelated ... we need them for this |
Codecov Report
@@ Coverage Diff @@
## master #12264 +/- ##
==========================================
+ Coverage 42.23% 42.24% +0.01%
==========================================
Files 699 706 +7
Lines 76959 77123 +164
==========================================
+ Hits 32500 32578 +78
- Misses 39094 39179 +85
- Partials 5365 5366 +1
Continue to review full report at Codecov.
|
|
It's better to move all codes about logger to another PR and this one depends that one. |
|
Then we will need to merge those changes first. The logger changes are entirely required for this to work |
Refactor Logger to make a logger interface and make it possible to wrap loggers for specific purposes.
Move the gitea doctor functions into its own module.
Use a logger for its messages instead of returning a results string[]
Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: 6543 <[email protected]>
Co-authored-by: 6543 <[email protected]>
|
Probably it does solve it yes |
This PR refactors the doctor code to move it to its own module. It changes the functions to use a passed in logger instead of using a results array.
Fix #12706