The Wayback Machine - https://web.archive.org/web/20200801161358/https://github.com/jhipster/generator-jhipster/pull/10624
Skip to content

/ generator-jhipster

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Switch to Angular CLI #10624

Open
wants to merge 3 commits into
base: master
from
Open

WIP Switch to Angular CLI #10624

wants to merge 3 commits into from

Conversation

@wmarques
Copy link
Contributor

wmarques commented Oct 15, 2019 •
edited

Fixes #10539

As discussed, given the opportunities offered by the Angular CLI, we can now extend their config with ours so IMO we should move into Angular CLI.

This offers some advantages:

  • Less config files
  • Less dependencies
  • Enjoy the benefits of Angular CLI (further optimisations, differential loading)

We could even go further with the Angular CLI schematics, for example we could do an Entity schematic to generate an entity page.

Still Todo:

  • Compare bundles (check drawbacks)
  • Remove old dependencies / useless files
  • ng test Jest support
  • PWA support
  • Travis tests are green
  • Tests are added where necessary
  • Documentation is added/updated where necessary
  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed
@wmarques wmarques changed the title Switch to Angular CLI WIP Switch to Angular CLI Oct 15, 2019
@wmarques wmarques force-pushed the wmarques:add-angular-cli branch from b38d226 to dd166b2 Oct 15, 2019
@DanielFran
Copy link
Member

DanielFran commented Dec 14, 2019

@wmarques Can you fix conflicts?
Would be awesome to have it ready for next release.
@wmarques
Copy link
Contributor Author

wmarques commented Dec 20, 2019

@DanielFran I think it will be for the v7, I want to test this well and to check if we don't lost performances
@wmarques wmarques added the 7.x label Dec 20, 2019
@qmonmert
qmonmert reviewed Jan 14, 2020
View changes
generators/client/templates/angular/package.json.ejs Outdated
@@ -60,6 +60,8 @@
"zone.js": "0.10.2"
},
"devDependencies": {
"@angular-builders/custom-webpack": "^8.2.0",

This comment has been minimized.

Sign in to view
Copy link
@qmonmert

qmonmert Jan 14, 2020

Contributor

"^8.2.0" => "8.2.0"
@qmonmert
qmonmert reviewed Jan 14, 2020
View changes
generators/client/templates/angular/package.json.ejs Outdated
@@ -60,6 +60,8 @@
"zone.js": "0.10.2"
},
"devDependencies": {
"@angular-builders/custom-webpack": "^8.2.0",
"@angular-devkit/build-angular": "^0.803.3",

This comment has been minimized.

Sign in to view
Copy link
@qmonmert

qmonmert Jan 14, 2020

Contributor

"^0.803.3" => "0.803.3"
@qmonmert
qmonmert reviewed Jan 14, 2020
View changes
generators/client/templates/angular/src/main/webapp/app/polyfills.ts.ejs
@@ -18,4 +18,4 @@
-%>
import 'core-js/proposals/reflect-metadata';
import 'zone.js/dist/zone';
require('../manifest.webapp');
//require('../manifest.webapp');

This comment has been minimized.

Sign in to view
Copy link
@qmonmert

qmonmert Jan 14, 2020

Contributor

so you can remove this line ?
@mraible
Copy link
Contributor

mraible commented Jan 17, 2020

This PR needs a rebase to fix conflicts.
@wmarques
Copy link
Contributor Author

wmarques commented Jan 17, 2020

Yep I'll work on it during the month
wmarques added 2 commits Oct 5, 2019
@wmarques
add simple config
dffab70
@wmarques
Add config for dev and prod mode
Loading status checks…
91cfa25
@wmarques wmarques force-pushed the wmarques:add-angular-cli branch from dd166b2 to 91cfa25 Mar 17, 2020
@wmarques
add build command
Loading status checks…
ff4494d
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@pascalgrimaud
Copy link
Member

pascalgrimaud commented May 30, 2020

@wmarques : what is the state of your PR ? The original ticket is opened for too long (8 months)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonmert qmonmert

Assignees
No one assigned
Labels
7.x area: enhancement 🔧 status: work in progress theme: angular
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Move back to angular cli
6 participants
@wmarques @DanielFran @mraible @CLAassistant @pascalgrimaud @qmonmert
You can’t perform that action at this time.