The Wayback Machine - https://web.archive.org/web/20201225224443/https://github.com/u-root/u-root/pull/1749
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESXi pxeboot support #1749

Draft
wants to merge 4 commits into
base: master
from
Draft

ESXi pxeboot support #1749

wants to merge 4 commits into from

Conversation

@hugelgupf
Copy link
Member

@hugelgupf hugelgupf commented Jul 2, 2020

Requires #1747 to be merged first. I'll be very happy when we do this the EFI way.

@hugelgupf hugelgupf force-pushed the hugelgupf:esxi-netboot branch 6 times, most recently from 0a51291 to d55ad68 Jul 2, 2020
@hugelgupf hugelgupf marked this pull request as draft Jul 3, 2020
@hugelgupf hugelgupf force-pushed the hugelgupf:esxi-netboot branch 2 times, most recently from 4c07f40 to 47a15bc Jul 5, 2020
hugelgupf added 4 commits Jul 2, 2020
Previously, we were generating invalid URLs in our custom parseURL
functions by using relative paths.

Our paths would be something like file://foobar/boot.cfg, which would
parse into

&url.URL{
  Scheme: "file",
  Host: "foobar",
  Path: "/boot.cfg",
}

But what we actually want is for it to parse into

&url.URL{
  Scheme: "file",
  Host: "",
  Path: "foobar/boot.cfg",
}

However, there is no valid representation of that because it's
ambiguous. The only valid thing would be where Path =
"/foobar/boot.cfg".

So, to trick the URL parser, we use Host = "." as a custom indicator.

Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
@hugelgupf hugelgupf force-pushed the hugelgupf:esxi-netboot branch from 47a15bc to 9a5a4e1 Jul 7, 2020
@yurinnick
Copy link

@yurinnick yurinnick commented Dec 4, 2020

Thanks for doing this! #1747 is merged, could you please merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.