Allow complex numbers as arguments of complex() #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
approved these changes
Aug 15, 2020
There was a problem hiding this comment.
I feel like parsing real and parsing imag can share a part of code but doesn't have any idea. @coolreader18 how do you think about it?
|
Suggestion: let real = if let Some(comp) = try_complex(real) {
comp
} else if let Some(s) = real.payload_if_subclass::<PyString>() {
...
} else {
...
};
// imag same as real
...
let result = Complex64::new(real.re - imag.im, real.im + imag.re);
... |
youknowone
reviewed
Aug 15, 2020
vm/src/obj/objcomplex.rs
Outdated
| f.to_f64() | ||
| } | ||
| s @ PyString => { | ||
| let real: Complex64 = match real { |
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3/library/functions.html#complex
Complex numbers can be arguments of complex()