Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd javadoc and inline comments to HashMap.java #1395
Conversation
|
You may have to re-pull because upstream master HashMap.java just got updated |
|
Hi @rbshealy please review this Thanks |
| public int hashing(int key) { | ||
| int hash = key % hsize; | ||
| if (hash < 0) | ||
| hash += hsize; | ||
| return hash; | ||
| } | ||
|
|
rbshealy
Aug 7, 2020
Contributor
un-delete this
un-delete this
afadhitya
Aug 7, 2020
Author
Actually for this thing I've change it to private
Actually for this thing I've change it to private
|
Hi @rbshealy I have an updated |
|
Looks great! The only thing left is to un-delete the hashing method |
|
Hi @rbshealy i've done un-delete hashing method |
|
great work! This addresses the issue pretty well 👍🏻 |
|
Hi @StepfenShawn could you please review then merge this if necessary? |
|
|
||
| /** | ||
| * Get the next node after the current node | ||
| * @return Node next node | ||
| */ |
rbshealy
Aug 16, 2020
Contributor
Fix indentation example
Fix indentation example
rbshealy
Aug 16, 2020
•
Contributor
Before this gets merged, I just re-checked it and found some indentation errors, can you fix these? I will approve all changes after you do so
Before this gets merged, I just re-checked it and found some indentation errors, can you fix these? I will approve all changes after you do so
I added a javadoc comment and made a little change to the modifier method
closes #1394