Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
sed with -i option now runs silently #959
Conversation
Codecov Report
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
+ Coverage 97.28% 97.28% +<.01%
==========================================
Files 34 34
Lines 1289 1291 +2
==========================================
+ Hits 1254 1256 +2
Misses 35 35
Continue to review full report at Codecov.
|
| @@ -170,7 +170,7 @@ test('glob file names, with in-place-replacement', t => { | |||
| const result = shell.sed('-i', 'test', 'hello', `${t.context.tmp}/file*.txt`); | |||
| t.falsy(shell.error()); | |||
| t.is(result.code, 0); | |||
| t.is(result.toString(), 'hello1\n\nhello2\n'); // TODO: fix sed's behavior | |||
nfischer
Aug 13, 2019
Member
I think this TODO is about the double newline between hello1 and hello2, not the -i behavior. Could you file a github issue to track the double-newline thing?
I think this TODO is about the double newline between hello1 and hello2, not the -i behavior. Could you file a github issue to track the double-newline thing?
…o sed-i-quiet Updated gpg key to verify the commit
|
Hi all, is there anything preventing this PR from merging? |
Fixes issue #159 with shx