Make class.slots completely immutable #2163
Conversation
|
Ooh, better idea: make |
|
oh, that sounds great |
coolreader18
force-pushed
the
coolreader18/immutable-slots
branch
2 times, most recently
from
356d500 to
d0573a6
Compare
coolreader18
force-pushed
the
coolreader18/immutable-slots
branch
from
943db39 to
d7bdaf1
Compare
coolreader18
force-pushed
the
coolreader18/immutable-slots
branch
from
d7bdaf1 to
43b7a7b
Compare
|
@youknowone can you review? |
|
I will do it soon. I had a few busy days 😵 |
|
No problem, take your time :) |
derive/src/pyclass.rs
Outdated
| } | ||
| iter_chain![ | ||
| parse_quote! { | ||
| fn __extend_py_class( |
There was a problem hiding this comment.
can this also become #[extend_class]?
There was a problem hiding this comment.
extend_class works by just calling the #[extend_class]-marked method in the generated extend_class method; for a PyClassImpl that's the impl_extend_class method and for a trait/interface that's this "magic" method; extend_class can't substitute for the actual generated method.
| (@extract_slots($ctx:expr, $slots:expr, (slot $slot_name:ident), $value:expr)) => { | ||
| $slots.$slot_name = Some( | ||
| $crate::function::IntoPyNativeFunc::into_func($value) | ||
| ); | ||
| }; | ||
| (@extract_slots($ctx:expr, $class:expr, $name:expr, $value:expr)) => {}; | ||
| (@extract_attrs($ctx:expr, $slots:expr, (slot $slot_name:ident), $value:expr)) => {}; | ||
| (@extract_attrs($ctx:expr, $class:expr, $name:expr, $value:expr)) => { | ||
| $class.set_str_attr($name, $value); | ||
| }; |
There was a problem hiding this comment.
is there benefits to keep these parts in the same macro? i am curious if this is a sort of recommended convention or not.
There was a problem hiding this comment.
Sort of; I know that tokio does that with their macros; I think it keeps the logic encapsulated so that when there's a @extract_slots inside you know that it's in the same macro definition.
No description provided.