The Wayback Machine - https://web.archive.org/web/20201215131542/https://github.com/python/devguide/pull/269
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace and quoting issues identified by "make check" #269

Merged
merged 1 commit into from Sep 30, 2017

Conversation

@jeff5
Copy link
Contributor

@jeff5 jeff5 commented Sep 30, 2017

This fixes 11 of 12 complaints by make check, but there is still one I don't know what to do with:

PS devguide> .\make check
[2] .\gitbootcamp.rst:282: default role used
1 problem with severity 2 found.

I think this last is a false alarm, but there doesn't seem to be any escaping it short of change to rstlint.py to recognise literal blocks. The offending item is the command nested with backticks in:

$ git checkout `git rev-list -n 1 --before="yyyy-mm-dd hh:mm:ss" master`
@zware
zware approved these changes Sep 30, 2017
@zware
Copy link
Member

@zware zware commented Sep 30, 2017

I agree that the last one is a false-positive; we'll fix that in a separate PR (feel free to write that PR if you'd like :))

@zware zware merged commit 2b84294 into python:master Sep 30, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jeff5 jeff5 deleted the jeff5:cp-de-lint branch Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.